Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Tighter bound on asset types teleported so that weight is cheaper #6980

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

gilescope
Copy link
Contributor

If we can bound the assets then the teleport cost requires less weight as worst case cost is less. Fixes paritytech/cumulus#2392 where we were seeing teleports costing 38bn weight due to assuming there could be 100 different assets.

@gilescope gilescope added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T6-XCM This PR/Issue is related to XCM. B1-note_worthy Changes should be noted in the release notes T1-runtime This PR/Issue is related to the topic “runtime”. labels Mar 30, 2023
Copy link
Contributor

@ruseinov ruseinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks good to me, seems like Wild(All) approach is just a leftover from v2 era.

@ruseinov ruseinov added T1-runtime This PR/Issue is related to the topic “runtime”. and removed T1-runtime This PR/Issue is related to the topic “runtime”. labels Mar 30, 2023
@gilescope gilescope requested a review from KiChjang March 30, 2023 11:58
Copy link
Contributor

@KiChjang KiChjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like reserve asset transfers are already providing an upper limit there, so no reason why teleports don't have a bound.

@gilescope gilescope removed the T6-XCM This PR/Issue is related to XCM. label Mar 30, 2023
@gilescope
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit f45a5b4 into master Mar 30, 2023
@paritytech-processbot paritytech-processbot bot deleted the giles-cheaper-teleports branch March 30, 2023 16:24
ordian added a commit that referenced this pull request Apr 11, 2023
* master: (28 commits)
  Remove years from copyright notes (#7034)
  Onchain scraper in `dispute-coordinator` will scrape `SCRAPED_FINALIZED_BLOCKS_COUNT` blocks before finality (#7013)
  PVF: Minor refactor in workers code (#7012)
  Expose WASM bulk memory extension in execution environment parameters (#7008)
  Co #13699: Remove old calls (#7003)
  Companion for paritytech/substrate#13811 (#6998)
  PR review rules, include all rs files except weights (#6990)
  Substrate companion: Remove deprecated batch verification (#6999)
  Added `origin` to config for `universal_origin` benchmark (#6986)
  Cache `SessionInfo` on new activated leaf in `dispute-distribution` (#6993)
  Update Substrate to fix Substrate companions (#6994)
  Consolidate subsystem spans so they are all children of the leaf-activated root span (#6458)
  Avoid redundant clone. (#6989)
  bump zombienet version (#6985)
  avoid triggering unwanted room_id for the release notifs (#6984)
  Add crowdloan to SafeCallFilter (#6903)
  Drop timers for new requests of active participations (#6974)
  Use `SIGTERM` instead of `SIGKILL` on PVF worker version mismatch (#6981)
  Tighter bound on asset types teleported so that weight is cheaper (#6980)
  staking miner: less aggresive submissions (#6978)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expensive teleports
5 participants